llvmPackages: add asl20-llvm to licenses for v19+
#314347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per llvm/llvm-project#92394 contributions made after June 1st, 2024 are licensed exclusively under `Apache-2.0 WITH LLVM-exception` rather than dual licensed. As per this post, this change is timed so that it only affects version 19 and newer: https://discourse.llvm.org/t/relicensing-next-step-dropping-requirement-to-contribute-also-under-the-legacy-license/78351
rrbutani
added
the
6.topic: llvm/clang
RossComputerGuy
approved these changes
May 27, 2024
I didn't want us to forget to make this change and I wanted another pair of eyes on this change specifically — I've made mistakes here before. |
Sounds good, LGTM. Meanwhile, I'll try to fix the latest LLVM git update so we can merge that ASAP. Hopefully that'll make LLVM 19 smooth sailing when that releases in like a month or two. |
|
@alyssais: friendly ping |
alyssais
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As per llvm/llvm-project#92394 contributions made after June 1st, 2024 are licensed exclusively under
Apache-2.0 WITH LLVM-exceptionrather than dual licensed.As per this post, this change is timed so that it only affects version 19 and newer.
If I'm understanding correctly, I think this means we should add
licenses.asl20-llvmtollvm_meta.licenseforrelease_version >= 19.Previously: #217906.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.