Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openlp: 2.4.6 -> 3.1.2 #314882

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

openlp: 2.4.6 -> 3.1.2 #314882

wants to merge 2 commits into from

Conversation

jorsn
Copy link
Member

@jorsn jorsn commented May 26, 2024

Description of changes

looking for additional maintainers: I don't use OpenLP any more. I can stay a maintainer and help with non-trivial updates, but it would be very helpful to have someone using it, who notices updates and breakages.

Things done

  • Built on platform(s)
    • x86_64-linux (NixOS)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/). Functinality tested:
    • songs
    • bible verses
    • pdfs
    • presentations via libreoffice
    • pictures
    • videos
    • custom slides
    • web remote
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jorsn jorsn added the backport release-24.05 Backport PR automatically label May 26, 2024
@jorsn
Copy link
Member Author

jorsn commented May 26, 2024

I added the backport label because the old package was broken (#296477).

This did not show up in Hydra, since so far meta.hydraPlatforms = [ ] was set. I had thought that the package in lib.nix would be built, but I think it wasn't because it appears nowhere in nixpkgs, except as a passthrough of the frontend package.

Also, this breaks no other package.

@jorsn
Copy link
Member Author

jorsn commented May 26, 2024

@Green-D-683 @matj1 I would also appreciate your reviews, even if I can't formally request them.
Since you use OpenLP (I assume), it would be of great help if you could test whether the application works. Especially the libreoffice integration could be fragile.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/help-overriding-python-library-in-nixos-home-manager/38042/2

@mweinelt mweinelt removed their request for review May 26, 2024 20:40
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/openlp-update-to-3-1-2-looking-for-reviewers-and-co-maintainers/46034/1

@emilazy
Copy link
Member

emilazy commented Aug 9, 2024

This will need rebasing for #330855. Good luck with getting a co‐maintainer on board; it would be good to see this actively maintained again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure:OpenLP
4 participants