Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixVersions.stable: reference nixos-smoketets test #315878

Closed
wants to merge 2 commits into from
Closed

nixVersions.stable: reference nixos-smoketets test #315878

wants to merge 2 commits into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 30, 2024 •
edited
Loading

According to the previous nix maintainer, this test is critical for nix upgrades.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 requested review from RaitoBezarius and Ma27 as code owners May 30, 2024 12:35
This was referenced May 30, 2024
Merged
Merged
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 30, 2024
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 30, 2024
@Mic92 Mic92 changed the title nixVersions.stable: add misc test to nix tests nixVersions.stable: reference nixos-smoketets test May 30, 2024
@Mic92
Copy link
Member Author

Mic92 commented May 30, 2024

cc @mweinelt I went for nixos-smoketests. I hope this one is better?

@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 30, 2024
@Artturin
Copy link
Member

How about #315927 instead?

@Mic92
Copy link
Member Author

Mic92 commented May 30, 2024

Yes. This one looks better.

@Mic92 Mic92 closed this May 30, 2024
@Mic92 Mic92 deleted the nix branch May 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mic92 @Artturin