Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remnote: remove max-niederman as maintainer #317163

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

chewblacka
Copy link
Contributor

@chewblacka chewblacka commented Jun 4, 2024

Description of changes

Remove max-neiderman as maintainer.
Hasn't been active for over 2 years:
https://github.com/NixOS/nixpkgs/commits/nixos-unstable/pkgs/applications/misc/remnote/default.nix

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@chewblacka chewblacka marked this pull request as ready for review June 4, 2024 10:55
@AndersonTorres
Copy link
Member

AndersonTorres commented Jun 4, 2024

I will include theem at #290642

P.S.: is theem merely not maintaining this package, or it is something more general?

P.P.S.: @max-niederman I will mark you just in case

@chewblacka
Copy link
Contributor Author

P.S.: is theem merely not maintaining this package, or it is something more general?

He init'ed the package over 2 years ago. I have been sole maintainer since. Its mainly that he gets auto-added as a reviewer every time I make a PR which is really annoying.

Copy link
Member

@max-niederman max-niederman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all good with this.

@chewblacka
Copy link
Contributor Author

I'm all good with this.

Much appreciated!

@chewblacka
Copy link
Contributor Author

Can this be merged please? I have some package updates I'd like to push. Many thanks!

@h7x4 h7x4 merged commit d89558d into NixOS:master Jun 15, 2024
24 of 25 checks passed
@chewblacka chewblacka deleted the fix-remnote branch August 28, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants