Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showtime: init at 46.3 #318197

Merged
merged 1 commit into from
Aug 26, 2024
Merged

showtime: init at 46.3 #318197

merged 1 commit into from
Aug 26, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jun 8, 2024 •
edited
Loading

Description of changes

showtime is a new video player for GNOME, meant to eventually replace totem

draft for now as it depends on gtk >= 4.15

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

isabelroses
isabelroses reviewed Jun 8, 2024
View reviewed changes
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapGAppsHook should be wrapGAppsHook4

@getchoo getchoo force-pushed the pkgs/showtime/init branch 2 times, most recently from c4f5fb5 to 69a64b8 Compare July 15, 2024 19:38
@getchoo getchoo changed the title showtime: init at 0-unstable-2024-06-07 showtime: init at 46.3 Jul 15, 2024
@Aleksanaa Aleksanaa self-requested a review July 18, 2024 15:02
@onny
Copy link
Contributor

onny commented Jul 21, 2024

Result of nixpkgs-review pr 318197 run on x86_64-linux 1

1 package built:
  • showtime

@onny
Copy link
Contributor

onny commented Jul 21, 2024

works for me :)

@getchoo getchoo marked this pull request as ready for review July 21, 2024 22:23
@getchoo
Copy link
Member Author

getchoo commented Jul 21, 2024

Thanks for testing it out! I'll open this for review in that case

Fair warning though: this appears to be bugged on NVIDIA cards. Haven't been able to play with it much just yet, but it may be something to do with the gtk4 plugin of gst-plugins-rs. I hope we can get some more testing done here

Aleksanaa
Aleksanaa approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others are okay

pkgs/by-name/sh/showtime/package.nix Outdated Show resolved Hide resolved
@onny
Copy link
Contributor

onny commented Aug 2, 2024

Result of nixpkgs-review pr 318197 run on x86_64-linux 1

1 package built:
  • showtime

@onny
Copy link
Contributor

onny commented Aug 2, 2024

Thanks for testing it out! I'll open this for review in that case

Fair warning though: this appears to be bugged on NVIDIA cards. Haven't been able to play with it much just yet, but it may be something to do with the gtk4 plugin of gst-plugins-rs. I hope we can get some more testing done here

Also have this problem on my notebook with an Nvidia card. Video plays but the video has only one signle color

Aleksanaa
Aleksanaa approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me on Radeon 780M.

@Aleksanaa Aleksanaa merged commit d049c8d into NixOS:master Aug 26, 2024
28 checks passed
@getchoo getchoo deleted the pkgs/showtime/init branch August 26, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelroses isabelroses isabelroses left review comments

@linsui linsui linsui approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@getchoo @onny @linsui @Aleksanaa @isabelroses