Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak: 24.0.5 -> 25.0.1 #318814

Merged
merged 3 commits into from
Jun 22, 2024
Merged

keycloak: 24.0.5 -> 25.0.1 #318814

merged 3 commits into from
Jun 22, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Jun 10, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao
Copy link
Member Author

NickCao commented Jun 10, 2024

        > caused by:
       >  rendering release-notes/rl-2205.section.md
       >
       > caused by:
       > bad local reference, id #opt-services.keycloak.settings.hostname-strict-backchannel not known

What should we do about this?

@teutat3s
Copy link
Member

Maybe change it to a string services.keycloak... without the reference/link to the option?

@NickCao
Copy link
Member Author

NickCao commented Jun 11, 2024

Marking draft due to some regression: keycloak/keycloak#30306

@NickCao NickCao marked this pull request as draft June 11, 2024 01:28
@NickCao NickCao changed the title keycloak: 24.0.5 -> 25.0.0 keycloak: 24.0.5 -> 25.0.1 Jun 20, 2024
@NickCao NickCao marked this pull request as ready for review June 20, 2024 15:06
@NickCao
Copy link
Member Author

NickCao commented Jun 20, 2024

Marking draft due to some regression: keycloak/keycloak#30306

This, together with a lot other regressions are now fixed.

@teutat3s
Copy link
Member

Test nixosTests.keycloak.mysql fails for me locally, not sure if it's the same failure though.

@leona-ya leona-ya merged commit 6311a7a into NixOS:master Jun 22, 2024
7 of 8 checks passed
@NickCao NickCao deleted the keycloak branch June 22, 2024 14:52
@teutat3s
Copy link
Member

teutat3s commented Jun 27, 2024

Would it be okay to backport this to 24.05? Or would we only do that if security fixes were part of the new version?
EDIT: We did set a precedent with #271845 once.

@NickCao
Copy link
Member Author

NickCao commented Jun 27, 2024

Would it be okay to backport this to 24.05?

Maybe not.

EDIT: We did set a precedent with #271845 once.

That was due to the prior version going to EOL right?

@teutat3s
Copy link
Member

That's the case here as well, support for 24.0.x ended on 2024-06-10 AFAICT.

@NickCao
Copy link
Member Author

NickCao commented Jun 29, 2024

That's the case here as well, support for 24.0.x ended on 2024-06-10 AFAICT.

Trying out the backport in #323480, however the release binary fails to launch for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants