-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
j4-dmenu-desktop: unstable-2023-09-12 -> r3.1 #319066
base: master
Are you sure you want to change the base?
Conversation
f8850e4
to
38d31bc
Compare
@ericsagnes You're marked as a maintainer of this package, could I please get a review? |
38d31bc
to
34ef0a6
Compare
This PR also solves the memory hogging/leak problem of j4. I observe increasing RAM usage over time. j4 process left in the background after a program is launched. This is after 6 hours, 1.3 GB of RAM usage. It also uses a constant but low amount of CPU. |
34ef0a6
to
4bfd221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'm the main dev behind the r3.0 and r3.1 releases of j4-dmenu-desktop. I have reviewed this PR and it looks like it works well. I would have strongly preferred using the newly introduced Meson build system instead of CMake as noted in BUILDING.md, but both build systems should be fully functional.
I could look into doing this as a follow up PR. I'm hesitant to make any more changes to this PR, I don't wish to further delay getting it merged. |
Description of changes
fmt
dependencyspdlog
dependency-DNO_DOWNLOAD=ON
Upstream changelog: https://github.com/enkore/j4-dmenu-desktop/blob/r3.1/CHANGELOG
Changes since unstable revision: enkore/j4-dmenu-desktop@7e3fd04...r3.1
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.