[Backport release-24.05] liblxi: fix darwin build, use finalAttrs #319868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
(cherry picked from commit 78da6b3)
13 tasks
| pname = "liblxi"; | ||
| version = "1.20"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "lxi-tools"; | ||
| repo = "liblxi"; | ||
| rev = "v${version}"; |
There was a problem hiding this comment.
The finalAttrs pattern is not really helpful to override version, because the hash is not updated at the same time. See #310373 and #315337 (comment). There is no clear path forward, yet, but migrating to the finalAttrs pattern is not an improvement, imho.
There was a problem hiding this comment.
One of the reasons finalAttrs appeals to me is that I can do something like this.
somePackage.overrideAttrs (previousAttrs: {
version = newVersion;
src = previousAttrs.src.overrideAttrs {
outputHash = newHash;
};
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.05, triggered by a label in #311131.