-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "argsOverride" from linux kernel #32014
Conversation
argsOverride were introduced in 31fa2cd (NixOS#1654). It seems simpler to just override the default values with the attrs themselves. It also makes it more intuitive to use. (See NixOS#31596).
Depreciation warning is cool. |
can we label this as kernel/merge once rebased ? its is useful |
rebase ? |
Retrospectively, I think this is a bad idea. there is no reason to merge the full "args" attrset into the final derivation. We should really make buildLinux overridable. |
Isn't it already the case? EDIT: Note the usecase for introducing argsOverride should be adressed too by #31610 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict
Motivation for this change
It is a bit strange to use these argsOverride attribute because it does not play well with the .override mechanism. The current situation is also inconsistent since #31596 was merged.
Things done
This patch unifies the syntax for all the kernels by removing the argsOverride support and merging the input args after the default values, making everything overridable.
A deprecation warning was also introduced for users relying on that feature.