Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.hdmedians: modernize, fix testing, adopt #320901

Closed
wants to merge 1 commit into from

Conversation

TomaSajt
Copy link
Contributor

Description of changes

This PR refactors the hdmedians python package to use the more modern python packaging methods.

The testing logic was not workign previously, this PR addresses that also.
Note: pynose is used in place of nose, since pynose has python >=3.12 support.

Also, the license of the project changed in 2007, but hasn't been updated to reflect that inside nixpkgs. This was corrected in this PR.

I added myself to the maintainer list, since I maintain another package depending on this package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@TomaSajt TomaSajt added 0.kind: package adoption Requests for adopting packages that have no maintainers and removed 0.kind: package adoption Requests for adopting packages that have no maintainers labels Jun 19, 2024
@natsukium
Copy link
Member

pynose violates the license and will be removed in #325669
If you need nose for testing, please disable tests in 3.12.

@TomaSajt TomaSajt closed this Jul 9, 2024
@Sigmanificient Sigmanificient added the 0.kind: package adoption Requests for adopting packages that have no maintainers label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants