Fix switch-to-configuration-ng on WSL #321662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have the format strings include the proper content, we must use `with_context()`.
The switch-to-configuration-ng program is able to be called in two different contexts, (1) when being called as root by as the entrypoint to NixOS switching (often from nixos-rebuild), and (2) when performing user activation. On WSL, calling the child process for the latter context appears to not work without also setting the GID of the child. Setting the GID for the child process is likely the right thing to do regardless of the host system being WSL.
|
@ofborg test switchTestNg |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4148 |
|
@dasJ could I get a review from you on this one? I apologize as I realize you're not directly tied to the maintenance of this, but there isn't really any once else I can think of to pull in and review this one. |
isabelroses
approved these changes
Jul 19, 2024
jmbaur
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #319529
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.