Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick-webapps: init at 0-unstable-2024-08-05 #322226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

quick-webapps: init at 0-unstable-2024-08-05 #322226

wants to merge 1 commit into from
+7,145 −0

Conversation

ahoneybun
Copy link
Contributor

@ahoneybun ahoneybun commented Jun 24, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ahoneybun ahoneybun mentioned this pull request Jun 24, 2024
Open
a-kenji
a-kenji approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess I have to link to:
#327063

a-kenji
a-kenji suggested changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream name changed:
https://github.com/elevenhsoft/WebApps

@ahoneybun
Copy link
Contributor Author

ahoneybun commented Aug 4, 2024 •
edited
Loading

The upstream name changed: https://github.com/elevenhsoft/WebApps

The developer said that is is Quick WebApps:

Screenshot_20240804_083944

@a-kenji
Copy link
Contributor

a-kenji commented Aug 4, 2024

Yes, but you are using the name to derive the repo.
And look at the current repo.

@ahoneybun
Copy link
Contributor Author

Yes, but you are using the name to derive the repo. And look at the current repo.

Sorry I don't follow?

@a-kenji
Copy link
Contributor

a-kenji commented Aug 4, 2024

Yes, but you are using the name to derive the repo. And look at the current repo.

Sorry I don't follow?

The repo argument of the fetchFromGitHub function is derived from pname, meaning the src points to a not anymore existing github repo. Which makes it impossible to build the package.

@ahoneybun
Copy link
Contributor Author

Yes, but you are using the name to derive the repo. And look at the current repo.

Sorry I don't follow?

The repo argument of the fetchFromGitHub function is derived from pname, meaning the src points to a not anymore existing github repo. Which makes it impossible to build the package.

It built fine for me? I think I'm following but the logic of how it is currently tracks.

@ahoneybun
Copy link
Contributor Author

Oh I see now that is new.

@ahoneybun ahoneybun changed the title quick-webapps: init at 0-unstable-2024-06-24 quick-webapps: init at 0-unstable-2024-08-05 Aug 6, 2024
@ahoneybun ahoneybun force-pushed the init-quickwebapps branch 3 times, most recently from 2f3ebf2 to 17107a6 Compare August 6, 2024 00:21
@a-kenji a-kenji self-requested a review August 6, 2024 08:34
SuperSandro2000
SuperSandro2000 reviewed Aug 23, 2024
View reviewed changes
pkgs/by-name/qu/quick-webapps/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qu/quick-webapps/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qu/quick-webapps/package.nix
postInstall = ''
wrapProgram "$out/bin/${pname}" \
--suffix XDG_DATA_DIRS : "${cosmic-icons}/share" \
--prefix LD_LIBRARY_PATH : ${
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid LD_LIBRARY_PATH by using patchelf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure about how to go about that but I'm not against if someone does it as long as it works.

pkgs/by-name/qu/quick-webapps/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/qu/quick-webapps/package.nix Outdated Show resolved Hide resolved
This was referenced Aug 24, 2024
Open
Closed
@Thatoo
Copy link

Thatoo commented Aug 24, 2024

Can it be backported to 24.05 to be integrated into https://github.com/lilyinstarlight/nixos-cosmic flake that indeed work with stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@a-kenji a-kenji a-kenji approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahoneybun @a-kenji @Thatoo @SuperSandro2000 @wegank