Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pidginPackages: move __attrsFailEvaluation to allow deeper evaluation #323867

Merged

Conversation

philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Jul 1, 2024

Description of changes

The test (nix-build pkgs/test/release/default.nix) test continues to pass.

These lines were added in #269356.

New derivations reported:

--- /dev/fd/63	2024-07-04 10:21:33.667962671 -0700
+++ /dev/fd/62	2024-07-04 10:21:33.667962671 -0700
@@ -51996,8 +51996,34 @@
   "pidginPackages.pidgin-sipe",
   "pidginPackages.pidgin-skypeweb",
   "pidginPackages.pidgin-window-merge",
   "pidginPackages.pidgin-xmpp-receipts",
+  "pidginPackages.pidginPackages.pidgin",
+  "pidginPackages.pidginPackages.pidgin-carbons",
+  "pidginPackages.pidginPackages.pidgin-indicator",
+  "pidginPackages.pidginPackages.pidgin-latex",
+  "pidginPackages.pidginPackages.pidgin-mra",
+  "pidginPackages.pidginPackages.pidgin-msn-pecan",
+  "pidginPackages.pidginPackages.pidgin-opensteamworks",
+  "pidginPackages.pidginPackages.pidgin-osd",
+  "pidginPackages.pidginPackages.pidgin-otr",
+  "pidginPackages.pidginPackages.pidgin-sipe",
+  "pidginPackages.pidginPackages.pidgin-skypeweb",
+  "pidginPackages.pidginPackages.pidgin-window-merge",
+  "pidginPackages.pidginPackages.pidgin-xmpp-receipts",
+  "pidginPackages.pidginPackages.purple-discord",
+  "pidginPackages.pidginPackages.purple-facebook",
+  "pidginPackages.pidginPackages.purple-googlechat",
+  "pidginPackages.pidginPackages.purple-hangouts",
+  "pidginPackages.pidginPackages.purple-lurch",
+  "pidginPackages.pidginPackages.purple-matrix",
+  "pidginPackages.pidginPackages.purple-mm-sms",
+  "pidginPackages.pidginPackages.purple-plugin-pack",
+  "pidginPackages.pidginPackages.purple-signald",
+  "pidginPackages.pidginPackages.purple-slack",
+  "pidginPackages.pidginPackages.purple-vk-plugin",
+  "pidginPackages.pidginPackages.purple-xmpp-http-upload",
+  "pidginPackages.pidginPackages.tdlib-purple",
   "pidginPackages.purple-discord",
   "pidginPackages.purple-facebook",
   "pidginPackages.purple-googlechat",
   "pidginPackages.purple-hangouts",

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@lucasew
Copy link
Contributor

lucasew commented Jul 1, 2024

Result of nixpkgs-review pr 323867 run on x86_64-linux 1

@lucasew
Copy link
Contributor

lucasew commented Jul 1, 2024

Derivation-wise LGTM

The test (`nix-build pkgs/test/release/default.nix`) continues to pass.
@philiptaron philiptaron force-pushed the __attrsFailEvaluation/pidginPackages branch from 559c087 to 3abc5f7 Compare July 4, 2024 17:22
@philiptaron philiptaron requested review from infinisil and removed request for lf- July 4, 2024 17:23
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@infinisil infinisil merged commit 0695766 into NixOS:master Jul 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants