Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2: 2.30.4 -> 2.30.5 #324512

Merged
merged 2 commits into from
Aug 3, 2024
Merged

SDL2: 2.30.4 -> 2.30.5 #324512

merged 2 commits into from
Aug 3, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 4, 2024 •
edited
Loading

Changes: https://github.com/libsdl-org/SDL/releases/tag/release-2.30.5

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from cpages July 4, 2024 09:27
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4341

@eljamm
Copy link
Contributor

eljamm commented Jul 30, 2024

Should we also format this with nixfmt-rfc-style?

@trofi
Copy link
Contributor Author

trofi commented Jul 30, 2024

Applied formatting in the separate commit.

eljamm
eljamm approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This LGTM

@pbsds
Copy link
Member

pbsds commented Aug 3, 2024

pygame{,-ce,-sdl2} and jazz2 builds fine, LGTM

@pbsds pbsds merged commit 4b25d1a into NixOS:staging Aug 3, 2024
28 of 29 checks passed
@trofi trofi deleted the SDL2-update branch August 3, 2024 05:42
@pbsds pbsds mentioned this pull request Aug 7, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@eljamm eljamm eljamm approved these changes

@cpages cpages Awaiting requested review from cpages

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trofi @nixos-discourse @eljamm @pbsds @tobim