Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt5: remove __attrsFailEvaluation as all attrsets evaluate #324622

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Jul 4, 2024

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

New derivations reported: https://gist.github.com/philiptaron/553c4bf5385d6648ac778099bf47977e

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron changed the title qt5.srcs: remove __attrsFailEvaluation qt5: remove __attrsFailEvaluation as all attrsets evaluate Jul 4, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@infinisil infinisil merged commit 14449c6 into NixOS:master Jul 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants