Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages: allow one level of introspection before applying __attrsFailEvaluation #324675

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

New derivations reported: https://gist.github.com/philiptaron/5b9292e9972ec1e18f01fc1cb5e8b77a

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@infinisil infinisil merged commit 224dedb into NixOS:master Jul 25, 2024
24 checks passed
@philiptaron philiptaron deleted the __attrsFailEvaluation/coq branch July 26, 2024 15:59
@philiptaron
Copy link
Contributor Author

I accidentally removed recurseIntoAttrs for coqPackages. @mweinelt fixed it in #330205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants