Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javaPackages.compiler.adoptopenjdk: all attrsets evaluate, so remove __attrsFailEvaluation #324680

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

New derivations reported:

--- /dev/fd/63	2024-07-04 14:26:57.697312468 -0700
+++ /dev/fd/62	2024-07-04 14:26:57.697312468 -0700
@@ -31717,8 +31717,34 @@
   "jasper",
   "java-language-server",
   "java-service-wrapper",
   "javaCup",
+  "javaPackages.compiler.adoptopenjdk-11.jdk-hotspot",
+  "javaPackages.compiler.adoptopenjdk-11.jdk-openj9",
+  "javaPackages.compiler.adoptopenjdk-11.jre-hotspot",
+  "javaPackages.compiler.adoptopenjdk-11.jre-openj9",
+  "javaPackages.compiler.adoptopenjdk-13.jdk-hotspot",
+  "javaPackages.compiler.adoptopenjdk-13.jdk-openj9",
+  "javaPackages.compiler.adoptopenjdk-13.jre-hotspot",
+  "javaPackages.compiler.adoptopenjdk-13.jre-openj9",
+  "javaPackages.compiler.adoptopenjdk-14.jdk-hotspot",
+  "javaPackages.compiler.adoptopenjdk-14.jdk-openj9",
+  "javaPackages.compiler.adoptopenjdk-14.jre-hotspot",
+  "javaPackages.compiler.adoptopenjdk-14.jre-openj9",
+  "javaPackages.compiler.adoptopenjdk-15.jdk-hotspot",
+  "javaPackages.compiler.adoptopenjdk-15.jdk-openj9",
+  "javaPackages.compiler.adoptopenjdk-15.jre-hotspot",
+  "javaPackages.compiler.adoptopenjdk-15.jre-openj9",
+  "javaPackages.compiler.adoptopenjdk-16.jdk-hotspot",
+  "javaPackages.compiler.adoptopenjdk-16.jdk-openj9",
+  "javaPackages.compiler.adoptopenjdk-16.jre-hotspot",
+  "javaPackages.compiler.adoptopenjdk-16.jre-openj9",
+  "javaPackages.compiler.adoptopenjdk-17.jdk-hotspot",
+  "javaPackages.compiler.adoptopenjdk-17.jre-hotspot",
+  "javaPackages.compiler.adoptopenjdk-8.jdk-hotspot",
+  "javaPackages.compiler.adoptopenjdk-8.jdk-openj9",
+  "javaPackages.compiler.adoptopenjdk-8.jre-hotspot",
+  "javaPackages.compiler.adoptopenjdk-8.jre-openj9",
   "javaPackages.compiler.corretto11",
   "javaPackages.compiler.corretto17",
   "javaPackages.compiler.corretto19",
   "javaPackages.compiler.corretto21",

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 4, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@infinisil infinisil merged commit 632837e into NixOS:master Jul 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants