cudaPackages: move __attrsFailEvaluation to allow deeper inspection #324685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
ofborg
bot
added
10.rebuild-darwin: 0
philiptaron
force-pushed
the
__attrsFailEvaluation/cuda
branch
from
9fe4a24
to
31e3a94
Compare
ConnorBaker
approved these changes
Jul 18, 2024
Comment on lines
+52
to
+54
| # Without this, if we use `final.callPackage` and a package accepts `cudaPackages` as an | ||
| # argument, it's provided with `cudaPackages` from the top-level scope, which is not what we | ||
| # want. We want to provide the `cudaPackages` from the final scope -- that is, the *current* |
There was a problem hiding this comment.
The change is fine within the scope of the PR, but the comment is misleading because packages under cudaPackages should not ask for the entire scope as an argment, they should ask for individual components CC @ConnorBaker
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
__attrsFailEvaluation#324619The test (
nix-build pkgs/test/release/default.nix) continues to pass.These lines were added in #269356.
New derivations reported: https://gist.github.com/philiptaron/f144fd6dc6a76e0f40dc52b5f489d219
Things done
nix-build pkgs/test/release/default.nix