Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test-pkgs, buildPackages, and buildFreebsd from excluded-attrnames-at-any-depth #324696

Conversation

philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

There is no difference in the package names generated.

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but I tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@philiptaron philiptaron force-pushed the __attrsFailEvaluation/excluded-attrnames-at-any-depth branch from 839a394 to 48d1364 Compare July 26, 2024 00:29
@philiptaron
Copy link
Contributor Author

Thanks, rebased.

@infinisil infinisil merged commit ae53779 into NixOS:master Jul 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants