Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.iodata: 1.0.0a2 -> 1.0.0a4 #324723

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

natsukium
Copy link
Member

Description of changes

Diff: Diff: theochem/iodata@refs/tags/1.0.0a2...v1.0.0a4

part of #311054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 324723 at 2729ee5 run on x86_64-linux 1

2 packages built successfully:
  • python311Packages.iodata
  • python312Packages.iodata

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 5, 2024
@ofborg ofborg bot requested a review from sheepforce July 5, 2024 05:20
Copy link
Member

@sheepforce sheepforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, LGTM!

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jul 5, 2024
@natsukium natsukium merged commit 17ed894 into NixOS:master Jul 5, 2024
30 of 31 checks passed
@natsukium natsukium deleted the iodata branch July 5, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants