changeme: init at 1.2.3 #325188
Open
changeme: init at 1.2.3 #325188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabaff any fixes for cerberus in this scenario. |
|
Do you use this? |
I currently do |
Sorry, i can't follow. Can you please be more specific? |
Tochiaha
force-pushed
the
changeme
branch
4 times, most recently
from
526bb56
to
8a52b9e
Compare
pkgs/by-name/ch/changeme/package.nix
Outdated
| checkPhase = '' | ||
| # allow to find the module helper during the test run | ||
| export PYTHONPATH=$PYTHONPATH:$PWD/tests | ||
| py.test changeme/tests |
There was a problem hiding this comment.
Please rely on pytestCheckHook and move the export to preCheck
Comment on lines
+73
to
+70
| mkdir -p $out/{bin,share/changeme} | ||
| cp -R * $out/share/changeme |
There was a problem hiding this comment.
Are those files not installed by python?
Tochiaha
force-pushed
the
changeme
branch
2 times, most recently
from
870f67b
to
05dfa5b
Compare
Aleksanaa
reviewed
Jul 24, 2024
Tochiaha
force-pushed
the
changeme
branch
2 times, most recently
from
d63560a
to
003b23e
Compare
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
natsukium
reviewed
Aug 17, 2024
Comment on lines
+27
to
+28
| build-system = with python3Packages; [ setuptools ]; | ||
|
|
There was a problem hiding this comment.
Suggested change
| build-system = with python3Packages; [ setuptools ]; |
There is no pyproject.toml or setup.py.
| logutils | ||
| lxml | ||
| netaddr | ||
| nose |
There was a problem hiding this comment.
Suggested change
| nose |
nose is a test dependency, and it should not be added to inputs.
see #326513
Comment on lines
+79
to
+81
| makeWrapper "${python3Packages.python.interpreter}" "$out/bin/changeme" \ | ||
| --set PYTHONPATH "$out/share/changeme/changeme.py" \ | ||
| --add-flags "$out/share/changeme/changeme.py" |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.