Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chiaki4deck: 1.7.3 -> 1.7.4 #329434

Merged
merged 3 commits into from
Jul 24, 2024
Merged

chiaki4deck: 1.7.3 -> 1.7.4 #329434

merged 3 commits into from
Jul 24, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jul 23, 2024

Description of changes

Tidying up after my patch made it upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@infinisil
Copy link
Member

The pkgs/by-name check failure was a problem on master, a rebase should fix it :)

@emilazy emilazy force-pushed the push-wswqkpvmtwnt branch from ad8f010 to 7dd75b8 Compare July 23, 2024 16:15
@ofborg ofborg bot requested a review from devusb July 23, 2024 16:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 23, 2024
@devusb
Copy link
Contributor

devusb commented Jul 24, 2024

Result of nixpkgs-review pr 329434 run on x86_64-linux 1

1 package built:
  • chiaki4deck

@devusb
Copy link
Contributor

devusb commented Jul 24, 2024

Thanks!

@emilazy emilazy merged commit 411e8cc into NixOS:master Jul 24, 2024
27 of 29 checks passed
@emilazy emilazy deleted the push-wswqkpvmtwnt branch August 26, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants