Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.pygogo: drop #329989

Merged
merged 1 commit into from
Jul 27, 2024
Merged

python311Packages.pygogo: drop #329989

merged 1 commit into from
Jul 27, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024

Description of changes

  • Bump version
  • Use nose3 instead of nose
  • Add myself as a maintainers, as current maintainers as not been keeping this package up to date

part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nose3 is worse than our nose, as it doesn’t support Python 3.12 at all and has disabled tests on 3.11, so this isn’t really an improvement. I see that upstream moved to nose3, but that’s after the release this bumps to (and involves no code changes, so our nose should continue to work anyway, I think).

This package seems to have been basically abandoned after 2021, has no reverse dependencies in tree, and clearly no active maintainer. It apparently has only ~9 reverse dependencies on PyPI (4 of which are by the author of this library), and only one of those reverse dependencies has been updated in the last few years. I think we should drop it instead; it will be easy to add back into the tree if anyone wants to package something that depends on it or if it starts being actively maintained again.

@Sigmanificient Sigmanificient changed the title python311Packages.pygogo: 0.13.2 -> 1.2.0; use nose3; add maintainer python311Packages.pygogo: drop Jul 27, 2024
@natsukium
Copy link
Member

Result of nixpkgs-review pr 329989 at fada29b run on x86_64-linux 1

@emilazy emilazy merged commit 2ae2272 into NixOS:master Jul 27, 2024
11 of 12 checks passed
@Sigmanificient Sigmanificient deleted the pygogo branch July 27, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants