Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Package.sure: drop nose dependency #330012

Merged
merged 3 commits into from
Jul 27, 2024
Merged

Conversation

Sigmanificient
Copy link
Member

Description of changes

Part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please migrate to pyproject = true; at the same time.

Maybe we should consider bumping this to 3.0a2, which seems to have removed the nose dependency entirely. I don’t know if it has breaking changes or not, though.

@Sigmanificient
Copy link
Member Author

Well there isn't any tags for 3.0.1a and it hasn't yet been updated on pypi too (https://pypi.org/project/sure/#files), so I believe the intent of the developer is to keep working on it before doing the release

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0a2 is on PyPI if you look at the right page, but it’s fine to wait for a final release.

pkgs/development/python-modules/sure/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built python{311,312}Packages.sure on x86_64-darwin, x86_64-linux, and aarch64-linux. Since thousands of packages depend on this one, I haven’t tested the full tree, but as this is a tests‐only change it shouldn’t propagate further. Retargetting to staging for the merge.

@emilazy emilazy marked this pull request as draft July 27, 2024 01:51
@emilazy emilazy changed the base branch from master to staging July 27, 2024 01:52
@emilazy emilazy marked this pull request as ready for review July 27, 2024 01:53
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emilazy emilazy merged commit daacb4e into NixOS:staging Jul 27, 2024
11 of 12 checks passed
@Sigmanificient Sigmanificient deleted the sure branch July 27, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants