-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Package.sure: drop nose dependency #330012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please migrate to pyproject = true;
at the same time.
Maybe we should consider bumping this to 3.0a2, which seems to have removed the nose dependency entirely. I don’t know if it has breaking changes or not, though.
ef213d3
to
1de0bd0
Compare
Well there isn't any tags for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0a2 is on PyPI if you look at the right page, but it’s fine to wait for a final release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built python{311,312}Packages.sure
on x86_64-darwin
, x86_64-linux
, and aarch64-linux
. Since thousands of packages depend on this one, I haven’t tested the full tree, but as this is a tests‐only change it shouldn’t propagate further. Retargetting to staging
for the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description of changes
Part of:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.