Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.selectors2: drop #330024

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024

Description of changes

part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 26, 2024
@Aleksanaa
Copy link
Member

@ofborg build python312Packages.selectors2

@emilazy
Copy link
Member

emilazy commented Jul 26, 2024

Please migrate to pyproject = true; and try pytestCheckHook.

@emilazy
Copy link
Member

emilazy commented Jul 26, 2024

Although with all that said, the upstream repository is archived, there are no in‐tree users, only 4 reverse dependencies on PyPI, and it only exists to polyfill the standard selectors library. Let’s drop it.

@Sigmanificient Sigmanificient changed the title python312Packages.selectors2: drop nose dependency python312Packages.selectors2: drop Jul 27, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You can delete pkgs/development/python-modules/selectors2/mapping-import.patch too.

@natsukium
Copy link
Member

Result of nixpkgs-review pr 330024 at 9c0a4e72 run on x86_64-linux 1

@emilazy emilazy merged commit 428548f into NixOS:master Jul 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants