Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 #330123

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jul 26, 2024

Description of changes

Prerequisite to get python3Packages.greatfet to work again.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@msanft
Copy link
Contributor Author

msanft commented Jul 26, 2024

Result of nixpkgs-review pr 330123 run on x86_64-linux 1

@kirillrdy
Copy link
Member

the reason you get 0 rebuilds is because commit message is wrong, it should be using python3Packages.cmsis-svd attribute

@msanft
Copy link
Contributor Author

msanft commented Jul 26, 2024

the reason you get 0 rebuilds is because commit message is wrong, it should be using python3Packages.cmsis-svd attribute

Interesting, thanks!

@msanft msanft changed the title pythonPackages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 python3Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 Jul 26, 2024
@msanft
Copy link
Contributor Author

msanft commented Jul 26, 2024

Result of nixpkgs-review pr 330123 run on x86_64-linux 1

@kirillrdy
Copy link
Member

the reason you get 0 rebuilds is because commit message is wrong, it should be using python3Packages.cmsis-svd attribute

Interesting, thanks!

ok so i am not sure why there are still no rebuilds, still investigaging, but commit message is more correct, as its what ofborg will use.

you can also use python312Packages.cmsis-svd as its currently default version of python

@msanft msanft changed the title python3Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 python312Packages.cmsis-svd: 0.4 -> 0.4-unstable-2024-01-25 Jul 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 26, 2024
@kirillrdy
Copy link
Member

ok mystery solved #330205

@msanft
Copy link
Contributor Author

msanft commented Jul 27, 2024

Result of nixpkgs-review pr 330123 run on x86_64-linux 1

4 packages built:
  • python311Packages.cmsis-svd
  • python311Packages.cmsis-svd.dist
  • python312Packages.cmsis-svd
  • python312Packages.cmsis-svd.dist

@kirillrdy kirillrdy requested a review from jollheef July 27, 2024 10:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 27, 2024
@msanft msanft requested a review from katexochen July 28, 2024 16:03
@kirillrdy kirillrdy merged commit c66091b into NixOS:master Jul 28, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants