Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(deprecated) cosmic-player: init at unstable-2024-03-13 #330167

Closed
wants to merge 16 commits into from
Closed

(deprecated) cosmic-player: init at unstable-2024-03-13 #330167

wants to merge 16 commits into from

Conversation

jh-devv
Copy link

@jh-devv jh-devv commented Jul 26, 2024 •
edited
Loading

Description of changes

Media Player for the COSMIC Desktop Environment.

Please note, the project is still heavily work in progress, so expect it not being so finished and stable!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 26, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 26, 2024
@jh-devv jh-devv mentioned this pull request Jul 26, 2024
Open
31 tasks
donovanglover
donovanglover reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs! Make sure to format your code with nixfmt-rfc-style available in shell.nix

pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 26, 2024
jh-devv and others added 3 commits July 28, 2024 17:11
@jh-devv @donovanglover
cosmic-player: format version
a2e2295 
Co-authored-by: Donovan Glover <donovan@dglover.co>
@jh-devv @donovanglover
cosmic-player: format repo name
7821245 
Co-authored-by: Donovan Glover <donovan@dglover.co>
@jh-devv @donovanglover
cosmic-player: format meta
a283df9 
Co-authored-by: Donovan Glover <donovan@dglover.co>
@jh-devv
Copy link
Author

jh-devv commented Jul 28, 2024

Welcome to nixpkgs! Make sure to format your code with nixfmt-rfc-style available in shell.nix

Thanks and well yeah... I forgot to do that :3

Aleksanaa
Aleksanaa reviewed Jul 28, 2024
View reviewed changes
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
jh-devv and others added 5 commits July 28, 2024 18:54
@jh-devv @Aleksanaa
cosmic-player: fix typo
02500af 
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
@jh-devv @Aleksanaa
cosmic-player: fix typo
797d4be 
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
@jh-devv @Aleksanaa
cosmic-player: fix typo
4c200b9 
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
@jh-devv @Aleksanaa
cosmic-player: format prefix
54db3a7 
Co-authored-by: Aleksana <alexander.huang.y@gmail.com>
@jh-devv
cosmic-player: remove post-patch
fe0e4ea
camerondugan
camerondugan suggested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@camerondugan camerondugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just needs some formatting to pass a test

pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/co/cosmic-player/package.nix Outdated Show resolved Hide resolved
jh-devv and others added 5 commits September 1, 2024 22:40
@jh-devv @camerondugan
cosmic-player: format
b02b3f9 
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
@jh-devv @camerondugan
cosmic-player: format
791decd 
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
@jh-devv @camerondugan
cosmic-player: format
ea6404c 
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
@jh-devv @camerondugan
cosmic-player: format
6e32ba7 
Co-authored-by: Cameron Dugan <Cameron.s.dugan@gmail.com>
@jh-devv
cosmic-player: lint
b3e6916 
forgot to do this before :3
ahoneybun
ahoneybun approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@ahoneybun ahoneybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 7, 2024
camerondugan
camerondugan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@camerondugan camerondugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I compiled and played an mp4

@jh-devv jh-devv closed this Oct 15, 2024
@jh-devv jh-devv deleted the cosmic-player branch October 15, 2024 22:12
@jh-devv jh-devv restored the cosmic-player branch October 15, 2024 22:12
@jh-devv jh-devv reopened this Oct 15, 2024
@jh-devv
Copy link
Author

jh-devv commented Oct 15, 2024

Silly me :3 Accidentally deleted the branch lol, it's back up now!

@Aleksanaa
Copy link
Member

Try updating version and switch to different ffmpeg version?

@jh-devv jh-devv closed this by deleting the head repository Oct 22, 2024
@jh-devv
Copy link
Author

jh-devv commented Oct 23, 2024 •
edited
Loading

Silly me :3 Accidentally deleted the branch lol, it's back up now!

Did this again! Can't revert since not at home 😭 Had some problems with the fork

@jh-devv
Copy link
Author

jh-devv commented Oct 23, 2024

New PR: #350710

@jh-devv jh-devv changed the title cosmic-player: init at unstable-2024-03-13 (deprecated) cosmic-player: init at unstable-2024-03-13 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camerondugan camerondugan camerondugan approved these changes

@ahoneybun ahoneybun ahoneybun approved these changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@donovanglover donovanglover Awaiting requested review from donovanglover

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jh-devv @Aleksanaa @donovanglover @ahoneybun @camerondugan @wegank @NixOSInfra