Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treewide: remove inactive maintainer viric #330232

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Treewide: remove inactive maintainer viric #330232

merged 3 commits into from
Jul 28, 2024

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jul 26, 2024 •
edited
Loading

Description of changes

#290642

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member Author

For the future merger:
Can we relax the restriction here and merge it ignoring the formatter?

@AndersonTorres AndersonTorres marked this pull request as ready for review July 26, 2024 18:05
Mic92
Mic92 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me let's wait 1-2 days for a response.

viric
viric approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@viric viric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm I'm an inactive maintainer.

@Mic92
Copy link
Member

Mic92 commented Jul 26, 2024 •
edited
Loading

Okay. Than we can merge it right away after eval.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 26, 2024
@tobim
Copy link
Contributor

tobim commented Jul 28, 2024

I want to add myself for perf, ghostscript, and logrotate. Can you make that change or should I open a follow up PR?

@AndersonTorres
release-lib: remove viric from crossMaintainers [orphans]
3be917a 
Since theey is not active from at least six years.
@AndersonTorres
treewide: remove viric from meta.maintainers [no orphans]
c9deae1 
Since theey is not active from at least six years.
@AndersonTorres
Copy link
Member Author

I want to add myself for perf, ghostscript, and logrotate. Can you make that change or should I open a follow up PR?

Better:
I will remove them from this PR. This way you can adopt them right now.

@github-actions github-actions bot removed the 6.topic: kernel The Linux kernel label Jul 28, 2024
@Aleksanaa
Copy link
Member

As the first person to encounter the unused with error due to this, can you share your thoughts on this? 😄🎙️

Mic92
Mic92 reviewed Jul 28, 2024
View reviewed changes
pkgs/applications/office/mmex/default.nix Outdated
@@ -71,7 +71,7 @@ stdenv.mkDerivation rec {
description = "Easy-to-use personal finance software";
homepage = "https://www.moneymanagerex.org/";
license = lib.licenses.gpl2Plus;
maintainers = with lib.maintainers; [ viric ];
maintainers = with lib.maintainers; [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with lib.maintainers; [ ];
maintainers = [ ];

@ofborg ofborg bot added 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jul 28, 2024
@Mic92
Copy link
Member

Mic92 commented Jul 28, 2024

I will fix empty maintainer lists using the with expression in a follow up PR.

@AndersonTorres
treewide: remove viric from meta.maintainers [orphans]
9a624d1 
Since theey is not active from at least six years.

All the packages on this commit became orphans.

---------------------------------------------------------------------------
There are files not covered by this commit, because they will be adopted
soon. Namely:

- pkgs/by-name/zs/zsync/package.nix
- pkgs/games/bsdgames/default.nix
- pkgs/misc/ghostscript/default.nix
- pkgs/os-specific/linux/kernel/perf/default.nix
- pkgs/tools/system/logrotate/default.nix
@AndersonTorres
Copy link
Member Author

As the first person to encounter the unused with error due to this, can you share your thoughts on this? 😄🎙️

I have mixed feelings about this.

In a first sight, I left the packages that way because a not so long time ago it was recommended - something about "it would be easier to add new maintainers in the future".

On the other hand, now that CI reports this as an error, there is no more room to never-ending discussions.

The net result of being shot by an error was positive!

@Mic92
Copy link
Member

Mic92 commented Jul 28, 2024

#330664

@Mic92
Copy link
Member

Mic92 commented Jul 28, 2024

I think overall having detection for unused with statements is quite useful, while having an exception just for maintainer fields would make it only more complex.

@matthiasbeyer
Copy link
Contributor

The discussion moved away from the actual topic of the PR AFAICS... how about we merge this?

@AndersonTorres
Copy link
Member Author

I will fix empty maintainer lists using the with expression in a follow up PR.

I can solve this with a bit of emacs-fu. Now CI is happy!
Nonetheless the cleanup will be needed in other expressions...

@Mic92 Mic92 merged commit 8968b1a into NixOS:master Jul 28, 2024
9 of 10 checks passed
@Mic92
Copy link
Member

Mic92 commented Jul 28, 2024

I thought, I pressed the merge button already... must have timed out.

@tobim tobim mentioned this pull request Jul 28, 2024
Merged
13 tasks
@Aleksanaa Aleksanaa mentioned this pull request Jul 30, 2024
Open
@bendlas
Copy link
Contributor

bendlas commented Aug 26, 2024

This removal PR has already been merged, despite not being grounded within community consensus. See #337478 (comment)

@viric be sure that we value your involvement and any time you may have to spare, helping with the packages you've maintained and others as well, and if you decide to come back, please don't hesitate to be added to maintainers again.

@thiagokokada thiagokokada mentioned this pull request Aug 26, 2024
Closed
13 tasks
@skeuchel skeuchel mentioned this pull request Sep 8, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@viric viric viric approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AndersonTorres @Mic92 @tobim @Aleksanaa @matthiasbeyer @bendlas @viric @SuperSandro2000