python312Packages.traittypes: unstable-2019-06-23 -> 0.2.1-unstable-2020-07-17 #330236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
requested changes
Jul 27, 2024
pyrox0
force-pushed
the
denose/traittypes
branch
from
671b502
to
d0af5d5
Compare
|
Thank you! Sorry for the final nit, but could you update the commit/PR title for the version change? |
pyrox0
changed the title
pyrox0
force-pushed
the
denose/traittypes
branch
from
d0af5d5
to
32a55f6
Compare
…020-07-17 Fixes test failures, and replaces np.int with int in tests, since that makes tests fail.
pyrox0
force-pushed
the
denose/traittypes
branch
from
32a55f6
to
e220b2c
Compare
|
Commit title updated |
SuperSandro2000
approved these changes
Jul 28, 2024
emilazy
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes test failures, and replaces np.int with int in tests, since that makes tests fail. Also makes the code more in line with modern Nix standards.
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.