Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jamesdsp: build with qt6 #330388

Merged
merged 1 commit into from
Jul 27, 2024
Merged

jamesdsp: build with qt6 #330388

merged 1 commit into from
Jul 27, 2024

Conversation

Tungsten842
Copy link
Member

@Tungsten842 Tungsten842 commented Jul 27, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to make a jamesdsp-qt5? But I'm not sure what the upstream situation looks like. Otherwise LGTM

Result of nixpkgs-review pr 330388 run on x86_64-linux 1

2 packages built:
  • jamesdsp
  • jamesdsp-pulse

@Tungsten842
Copy link
Member Author

We may want to make a jamesdsp-qt5? But I'm not sure what the upstream situation looks like. Otherwise LGTM

Result of nixpkgs-review pr 330388 run on x86_64-linux 1
2 packages built:

They explicitly recommend using Qt6, and the official Flatpak uses Qt6 as well. I don't really see any reason for having a Qt5 variant.

@wineee wineee merged commit f144fae into NixOS:master Jul 27, 2024
30 of 32 checks passed
@Tungsten842 Tungsten842 deleted the jamesdsp-qt6 branch July 27, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants