Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix format check minor fix #330400

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Nix format check minor fix #330400

merged 2 commits into from
Jul 27, 2024

Conversation

infinisil
Copy link
Member

Description of changes

Ping @NixOS/nix-formatting @Aleksanaa

Things done

Add a 👍 reaction to pull requests you find important.

@infinisil
workflows/check-nix-format: Fix reporting of renamed files
44f17f8 
When a file was renamed, it would previously report the old path as
being unformatted. This fixes it to report the new one instead.
@infinisil
workflows/check-nix-format: Allow testing in forks
a1c3699 
It seems like imposed limitation came from ofborg not running in forks,
which doesn't apply for standard GitHub actions:
88c60d9
@Aleksanaa
Copy link
Member

Eye diff looks okay

@infinisil infinisil merged commit a64e2c4 into NixOS:master Jul 27, 2024
25 checks passed
@infinisil infinisil deleted the nix-format-check-minor-fix branch July 27, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infinisil @Aleksanaa