Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pyquaternion: Remove nose dependency #330459

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 27, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Jul 27, 2024

Result of nixpkgs-review pr 330459 run on x86_64-linux 1

9 packages built:
  • nixpkgs-manual
  • python311Packages.bbox
  • python311Packages.bbox.dist
  • python311Packages.pyquaternion
  • python311Packages.pyquaternion.dist
  • python312Packages.bbox
  • python312Packages.bbox.dist
  • python312Packages.pyquaternion
  • python312Packages.pyquaternion.dist

@lucasew
Copy link
Contributor

lucasew commented Jul 27, 2024

This was added because of bpycv. If the bpycv passthru.tests and review works then LGTM

I just started nixpkgs-review tho

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330459 run on x86_64-linux 1

9 packages built:
  • nixpkgs-manual
  • python311Packages.bbox
  • python311Packages.bbox.dist
  • python311Packages.pyquaternion
  • python311Packages.pyquaternion.dist
  • python312Packages.bbox
  • python312Packages.bbox.dist
  • python312Packages.pyquaternion
  • python312Packages.pyquaternion.dist

@emilazy emilazy merged commit 56e1690 into NixOS:master Jul 28, 2024
29 of 30 checks passed
@pyrox0 pyrox0 deleted the denose/pyquaternion branch August 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants