Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.pyrfc3339: drop nose dependency #330496

Merged
merged 1 commit into from
Jul 27, 2024
Merged

python312Packages.pyrfc3339: drop nose dependency #330496

merged 1 commit into from
Jul 27, 2024

Conversation

Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 27, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Jul 27, 2024
Closed
emilazy
emilazy approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, how many test suites have we just not been running?

Doesn’t make things any worse than the status quo, so this is fine by me.

@emilazy
Copy link
Member

emilazy commented Jul 27, 2024

Result of nixpkgs-review pr 330496 run on x86_64-linux 1

24 packages built:
  • python311Packages.acme
  • python311Packages.acme.dist
  • python311Packages.certbot
  • python311Packages.certbot-dns-cloudflare
  • python311Packages.certbot-dns-cloudflare.dist
  • python311Packages.certbot-dns-google
  • python311Packages.certbot-dns-google.dist
  • python311Packages.certbot-dns-inwx
  • python311Packages.certbot-dns-inwx.dist
  • python311Packages.certbot-dns-ovh
  • python311Packages.certbot-dns-ovh.dist
  • python311Packages.certbot-dns-rfc2136
  • python311Packages.certbot-dns-rfc2136.dist
  • python311Packages.certbot-dns-route53
  • python311Packages.certbot-dns-route53.dist
  • python311Packages.certbot.dist
  • python311Packages.craft-store
  • python311Packages.craft-store.dist
  • python311Packages.hass-nabucasa
  • python311Packages.hass-nabucasa.dist
  • python311Packages.macaroonbakery
  • python311Packages.macaroonbakery.dist
  • python311Packages.pyrfc3339
  • python311Packages.pyrfc3339.dist

@emilazy emilazy merged commit 68e8a1b into NixOS:master Jul 27, 2024
13 of 14 checks passed
@Sigmanificient Sigmanificient deleted the pyrfc3339 branch July 27, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sigmanificient @emilazy