Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.prox-tv: drop nose dependency #330699

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@multun
Copy link
Member

multun commented Jul 28, 2024

I'm pretty sure the package can be dropped, it's very niche and hasn't been updated in 6 years. The change is a nice improvement though

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty dead and it has no in‐tree users, but it’s referenced in release-alternatives.nix, so, uh… I guess we can keep it?

pkgs/development/python-modules/prox-tv/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330699 run on x86_64-linux 1

5 packages built:
  • nixpkgs-manual
  • python311Packages.prox-tv
  • python311Packages.prox-tv.dist
  • python312Packages.prox-tv
  • python312Packages.prox-tv.dist

@emilazy emilazy merged commit 612cc22 into NixOS:master Jul 29, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants