Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.cassandra-driver: drop nose dependency; modernize #330760

Merged
merged 2 commits into from
Aug 9, 2024
Merged

python312Packages.cassandra-driver: drop nose dependency; modernize #330760

merged 2 commits into from
Aug 9, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 29, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from risicle July 29, 2024 04:31
@pyrox0 pyrox0 changed the title python312Packages.cassandra-driver: drop nose dependency python312Packages.cassandra-driver: drop nose dependency; modernize Jul 29, 2024
@emilazy emilazy mentioned this pull request Jul 29, 2024
Closed
emilazy
emilazy requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkgs/development/python-modules/cassandra-driver/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cassandra-driver/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/cassandra-driver/default.nix Show resolved Hide resolved
@pyrox0 pyrox0 requested a review from emilazy July 29, 2024 17:25
@risicle
Copy link
Contributor

risicle commented Jul 29, 2024

Broadly LGTM, nixpkgs-review reveals no new failures, macos 12 x86_64 & nixos x86_64

@pyrox0
Copy link
Member Author

pyrox0 commented Jul 29, 2024

Rebased to fix nixf-tidy since I forgot to remove mock.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 4, 2024
@emilazy emilazy merged commit b6f3032 into NixOS:master Aug 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@risicle risicle Awaiting requested review from risicle

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pyrox0 @risicle @SuperSandro2000 @emilazy @wegank