Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.envs: Drop nose dependency; modernize #330762

Merged
merged 2 commits into from
Aug 9, 2024
Merged

python312Packages.envs: Drop nose dependency; modernize #330762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fb2b84
python312Packages.envs: Drop nose dependency
pyrox0 Jul 29, 2024
5dc703c
python312Packages.envs: modernize
pyrox0 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions pkgs/development/python-modules/envs/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
click,
fetchPypi,
jinja2,
mock,
nose,
pytestCheckHook,
poetry-core,
pythonOlder,
terminaltables,
}:

Expand All @@ -16,44 +14,32 @@ buildPythonPackage rec {
version = "1.4";
pyproject = true;

disabled = pythonOlder "3.7";

src = fetchPypi {
inherit pname version;
hash = "sha256-nYQ1xphdHN1oKZ4ExY4r24rmz2ayWWqAeeb5qT8qA5g=";
};

nativeBuildInputs = [ poetry-core ];
build-system = [ poetry-core ];

propagatedBuildInputs = [
dependencies = [
click
jinja2
terminaltables
];

# test rely on nose
doCheck = pythonOlder "3.12";

nativeCheckInputs = [
mock
nose
];

checkPhase = ''
runHook preCheck
nativeCheckInputs = [ pytestCheckHook ];

nosetests --with-isolation
pytestFlagsArray = [ "envs/tests.py" ];

runHook postCheck
'';
disabledTests = [ "test_list_envs" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any idea why this (presumably) passed under nose? I’ll try to take a look at it if I have time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea honestly


pythonImportsCheck = [ "envs" ];

meta = with lib; {
meta = {
description = "Easy access to environment variables from Python";
mainProgram = "envs";
homepage = "https://github.com/capless/envs";
license = licenses.asl20;
maintainers = with maintainers; [ peterhoeg ];
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ peterhoeg ];
};
}