Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.hkdf: Drop nose dependency; modernize #330769

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 29, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An HKDF implementation is probably one of the less concerning cryptography libraries to not be updated for a decade, but I still don’t feel great about this.

autobahn only requires it (and spake2) optionally for some dead cryptocurrency thing that we should probably drop, but magic-wormhole depends on this through spake2. It looks like magic-wormhole was removed by Fedora along with hkdf and spake2 in favour of the Rust version from the same upstream.

I’m going to ask around about this, but it might be better just to drop this if we find the Rust version of Magic Wormhole to be an acceptable replacement.

@pyrox0
Copy link
Member Author

pyrox0 commented Jul 29, 2024

I’m going to ask around about this, but it might be better just to drop this if we find the Rust version of Magic Wormhole to be an acceptable replacement.

Sounds like a plan, I'll make this into a draft till there's a conclusion on that front.

@pyrox0 pyrox0 marked this pull request as draft July 29, 2024 17:26
@emilazy
Copy link
Member

emilazy commented Aug 10, 2024

After engaging with upstream, it looks like they’re actively maintaining spake2 again; the current unstable version has moved off hkdf to cryptography and also dropped the six dependency. We should probably wait for an official release, but it should be possible to drop hkdf after that.

@emilazy
Copy link
Member

emilazy commented Sep 22, 2024

The changes to spake2 were merged, but there’s no release yet; I’ve opened warner/python-spake2#20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants