Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pycontracts: drop #330791

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 29, 2024

Description of changes

Upstream is abandoned and this package no longer works on modern python versions. Since nothing else depends on it, drop the package.
Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This isn’t used by anything and upstream seems pretty dead; maybe it’d be best to drop it rather than patching it up a bunch? If there’s a reason to keep it I’d feel better about a proper .patch as this goes beyond my substituteInPlace comfort zone.

@pyrox0
Copy link
Member Author

pyrox0 commented Aug 10, 2024

I'll change this to drop instead, good call since there is a lot of patching.

@pyrox0 pyrox0 requested a review from natsukium as a code owner August 10, 2024 01:31
@pyrox0 pyrox0 changed the title python312Packages.pycontracts: drop nose dependency; modernize python312Packages.pycontracts: drop Aug 10, 2024
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge when ofborg-eval passes.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330791 run on aarch64-linux 1

@emilazy emilazy merged commit 36d2587 into NixOS:master Aug 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants