-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.{mwtypes,mwxml}: drop nose dependency; modernize #330805
Conversation
Thanks for dealing with this. |
There are 0.4.0 and 0.3.4 releases from this month that we could presumably use? |
Drops the nose dependency with the new patch
a92eff9
to
e766541
Compare
Tested and now using the regular pypi releases, and the patches still apply properly. Thanks for the suggestion to double-check that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 330805
run on aarch64-linux 1
8 packages built:
- python311Packages.mwtypes
- python311Packages.mwtypes.dist
- python311Packages.mwxml
- python311Packages.mwxml.dist
- python312Packages.mwtypes
- python312Packages.mwtypes.dist
- python312Packages.mwxml
- python312Packages.mwxml.dist
Description of changes
Updates these two packages to their latest releases to pull in new fixes, as well as adding patches that remove nose from their test suites. Upstream PRs have been sent, and they are linked next to the patches.
Part of #326513
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.