Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.flask-restful: drop nose dependency #330876

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Jul 31, 2024

This package is abandoned‐ish upstream and has been patched out of at least one package in‐tree (# flask-restful is unmaintained and breaks regularly, don't depend on it).

The remaining two users are wsme (unused, abandoned, repository is gone) and changedetection-io. The latter is actively updated and does still depend on this library upstream. @MikaelFangel Do you know if they have any intentions of moving off this deprecated library?

@MikaelFangel
Copy link
Contributor

I unfortunately don't know what the plans for changedetection-io is.

@Pizmovc
Copy link
Contributor

Pizmovc commented Aug 7, 2024

I can confirm that changedetection-io (which depends on this package) can now be built, while without this PR it can not be 👍

@gador
Copy link
Member

gador commented Aug 7, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 330876 run on x86_64-linux 1

7 packages built:
  • changedetection-io
  • changedetection-io.dist
  • nixpkgs-manual
  • python311Packages.flask-restful
  • python311Packages.flask-restful.dist
  • python312Packages.flask-restful
  • python312Packages.flask-restful.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

nixpkgs-manual:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

python311Packages.flask-restful.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/adzzwzaqysbhwxjmc7k2dgka2l3y2464-python3.11-flask-restful-0.3.10-dist' from 'daemon'
When evaluating attribute ‘python311Packages.flask-restful.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.flask-restful:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/adlp6hq0ff9h6ki67gqpl82gsg1i35hv-python3.11-flask-restful-0.3.10' from 'daemon'
When evaluating attribute ‘python311Packages.flask-restful’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.flask-restful.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/j9254kby615b2mj6qdj7m2kn112sfmwj-python3.12-flask-restful-0.3.10-dist' from 'daemon'
When evaluating attribute ‘python312Packages.flask-restful.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.flask-restful:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/c0czn83fqkm45awxyjiyldx8wxkwyai4-python3.12-flask-restful-0.3.10' from 'daemon'
When evaluating attribute ‘python312Packages.flask-restful’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/flask-restful/default.nix:76:5:

   |
76 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

@gador gador merged commit c26018c into NixOS:master Aug 7, 2024
25 checks passed
@emilazy
Copy link
Member

emilazy commented Aug 9, 2024

This didn’t actually remove the nose dependency.

@Sigmanificient
Copy link
Member Author

I forget to remove it in the arguments! 😥

@emilazy
Copy link
Member

emilazy commented Aug 10, 2024

No worries; feel free to open another PR for it or I might get around to it if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants