Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.clickhouse-driver: drop nose dependency #330959

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

This packages don't use nose

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Jul 31, 2024

It looks like the ClickHouse package works now; we might be able to run these tests?

@Sigmanificient
Copy link
Member Author

Still missing clickhouse as the comment says

@emilazy
Copy link
Member

emilazy commented Jul 31, 2024

What do you mean? We have a clickhouse package that seems to be building successfully on the unstable channel these days. I assume at the time of the comment it wasn’t working.

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 31, 2024

What do you mean? We have a clickhouse package that seems to be building successfully on the unstable channel these days. I assume at the time of the comment it wasn’t working.

Oh yeah, well added it, not much of a progression:

================== 30 passed, 1 skipped, 418 errors in 5.12s ===================

All errors seems due to

RuntimeError: Error during communication. b'Code: 210. DB::NetException: Connection refused (localhost:9000). (NETWORK_ERROR)\n\n'

What should I do?

@SuperSandro2000
Copy link
Member

Seems like this needs a running clickhouse which is pretty out of scope to add in this PR.

@SuperSandro2000 SuperSandro2000 merged commit 8895a01 into NixOS:master Aug 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants