Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix 2.24.1; nixVersions.latest: 2.23.3 -> 2.24.1 #331720

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Nix 2.24.1; nixVersions.latest: 2.23.3 -> 2.24.1 #331720

merged 2 commits into from
Aug 6, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 2, 2024 •
edited by philiptaron
Loading

Description of changes

Changelog: https://github.com/NixOS/nix/blob/2.24.1/doc/manual/src/release-notes/rl-2.24.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 removed the request for review from RaitoBezarius August 2, 2024 09:32
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 2, 2024
emilazy
emilazy previously requested changes Aug 2, 2024
View reviewed changes
pkgs/tools/package-management/nix/default.nix Outdated Show resolved Hide resolved
@emilazy emilazy mentioned this pull request Aug 2, 2024
Closed
13 tasks
@JohnRTitor JohnRTitor changed the title Nix 2.24.1 Nix 2.24.1; nixVersions.latest: 2.23.3 -> 2.24.1 Aug 2, 2024
@JohnRTitor
Copy link
Contributor

Mic I looked for a existing PR but found none before opening #331788, hopefully you don't mind me meddling with the PR title

@philiptaron
Copy link
Contributor

@oxalica nil fails to build due to nix __dump-builtins returning an error now. It was removed in NixOS/nix#8330.

@Aleksanaa
Copy link
Member

(Still the same question) @Ericson2314 @tomberek Should we try to build with meson in this release?

@tomberek
Copy link
Contributor

tomberek commented Aug 4, 2024

No.. I think we do the existing build this time and work on removing it in favor of meson for the next bump. There are still outstanding issues/prs: NixOS/nix#11224

Likely can get the meson build for next NixOS release? Hoping...

@nyabinary
Copy link
Contributor

Should this also include a git bump?

@Aleksanaa
Copy link
Member

Not necessary, we usually bump this separately

philiptaron
philiptaron approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 331720 run on x86_64-linux 1

1 package failed to build:
  • nil
5 packages built:
  • nixVersions.latest (nixVersions.nix_2_24)
  • nixVersions.latest.debug (nixVersions.nix_2_24.debug)
  • nixVersions.latest.dev (nixVersions.nix_2_24.dev)
  • nixVersions.latest.doc (nixVersions.nix_2_24.doc)
  • nixVersions.latest.man (nixVersions.nix_2_24.man)

nil was previously pinged; this PR could update that dependency to pin 2.23 instead of using nixVersions.latest.

llakala pushed a commit to llakala/nixos that referenced this pull request Aug 5, 2024
Use latest version of nix language, since many things keep improving …
cb2d195 
…(also see this PR for 2.24 soon NixOS/nixpkgs#331720)
@JohnRTitor
Copy link
Contributor

I have pinned the nil to 2.23 for now.

philiptaron
philiptaron approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that does it. Thanks @JohnRTitor.

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 331720 run on x86_64-linux 1

10 packages built:
  • nixVersions.latest
  • nixVersions.latest.debug
  • nixVersions.latest.dev
  • nixVersions.latest.doc
  • nixVersions.latest.man
  • nixVersions.nix_2_23
  • nixVersions.nix_2_23.debug
  • nixVersions.nix_2_23.dev
  • nixVersions.nix_2_23.doc
  • nixVersions.nix_2_23.man

@philiptaron philiptaron merged commit fb8fb78 into NixOS:master Aug 6, 2024
25 of 27 checks passed
@oxalica oxalica mentioned this pull request Aug 6, 2024
Merged
13 tasks
@philiptaron philiptaron mentioned this pull request Aug 20, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llakala llakala llakala approved these changes

@philiptaron philiptaron philiptaron approved these changes

@emilazy emilazy emilazy left review comments

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@Artturin Artturin Awaiting requested review from Artturin

@edolstra edolstra Awaiting requested review from edolstra

@tomberek tomberek Awaiting requested review from tomberek

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Mic92 @JohnRTitor @philiptaron @Aleksanaa @tomberek @nyabinary @emilazy @llakala