Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL2: 2.30.5 -> 2.30.6 #332071

Merged
merged 2 commits into from
Aug 8, 2024
Merged

SDL2: 2.30.5 -> 2.30.6 #332071

merged 2 commits into from
Aug 8, 2024

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Aug 3, 2024

Changes: https://github.com/libsdl-org/SDL/releases/tag/release-2.30.6

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member

AndersonTorres commented Aug 7, 2024

@trofi given that @cpages is dormant, please remove theem and change the maintainers to lib.teams.sdl.members.

I plan to clean up the expression, but let's wait it reach Master.

@trofi
Copy link
Contributor Author

trofi commented Aug 7, 2024

@trofi given that @cpages is dormant, please remove theem and change the maintainers to lib.teams.sdl.members.

Updated maintainers field.

@pbsds
Copy link
Member

pbsds commented Aug 8, 2024

these succeeded on x86_64-linux

nom build github:NixOS/nixpkgs/refs/pull/332071/head#jazz2
nom build github:NixOS/nixpkgs/refs/pull/332071/head#guile-sdl2
nom build github:NixOS/nixpkgs/refs/pull/332071/head#SDL2_ttf
nom build github:NixOS/nixpkgs/refs/pull/332071/head#SDL2_net
nom build github:NixOS/nixpkgs/refs/pull/332071/head#SDL2_gfx
nom build github:NixOS/nixpkgs/refs/pull/332071/head#SDL2_sound
nom build github:NixOS/nixpkgs/refs/pull/332071/head#SDL2_mixer
nom build github:NixOS/nixpkgs/refs/pull/332071/head#SDL2_image
nom build github:NixOS/nixpkgs/refs/pull/332071/head#python3Packages.pygame
nom build github:NixOS/nixpkgs/refs/pull/332071/head#python3Packages.pygame-ce
nom build github:NixOS/nixpkgs/refs/pull/332071/head#python3Packages.pygame-sdl2

@pbsds pbsds merged commit 4d7aab3 into NixOS:staging Aug 8, 2024
29 of 31 checks passed
@trofi trofi deleted the SDL2-update branch August 9, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants