Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-comp: unstable-2023-11-13 -> 1.0.0-alpha.1 #332249

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Aug 4, 2024

Description of changes

Do not merge, needs rustc --version: 1.80.0

Part of: #259641
Obligatory: #327063

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais
Copy link
Member

alyssais commented Aug 5, 2024

Are there user-facing changes in this upgrade, since this adds a new Cargo.lock?

@alyssais
Copy link
Member

alyssais commented Aug 6, 2024

Same question as in #332252 (comment). If there are user-facing changes, let's merge this concurrently with the Rust upgrade, so please retarget to staging.

@alyssais
Copy link
Member

alyssais commented Aug 7, 2024

   >   = note: /nix/store/d58kbbwjsdp3n5l91sx5pgg5i3p7llyh-binutils-2.42/bin/ld: cannot find -lpixman-1: No such file or directory

Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested building the merge with staging-next (for Rust 1.80).

@ofborg ofborg bot requested a review from alyssais August 7, 2024 11:29
@alyssais alyssais merged commit 83fa6da into NixOS:staging-next Aug 7, 2024
23 of 27 checks passed
@a-kenji a-kenji deleted the update/cosmic-comp branch August 7, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants