Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vencord: 1.9.5 -> 1.10.1 #332423

Merged
merged 9 commits into from
Sep 7, 2024
Merged

vencord: 1.9.5 -> 1.10.1 #332423

merged 9 commits into from
Sep 7, 2024

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Aug 5, 2024 •
edited
Loading

Description of changes

Vendicated/Vencord@v1.9.5...v1.10.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from FlafyDev and NotAShelf August 5, 2024 08:53
@mattpolzin
Copy link
Contributor

I got a hash mismatch building this on x86_64-linux.

error: hash mismatch in fixed-output derivation '/nix/store/n06k5gfwlkxfgwg2zal0xqlibgax94js-source.drv':
         specified: sha256-Xu93mSMF+DVAc90ma4cOM7bJSb2wOpRfm6w5pCGl+oQ=
            got:    sha256-RhczE44qTWpB1rzAKk5m/rEfhFNu7aXIzfKXpTxzO+o=

@Scrumplex
Copy link
Member Author

I got a hash mismatch building this on x86_64-linux.

error: hash mismatch in fixed-output derivation '/nix/store/n06k5gfwlkxfgwg2zal0xqlibgax94js-source.drv':
         specified: sha256-Xu93mSMF+DVAc90ma4cOM7bJSb2wOpRfm6w5pCGl+oQ=
            got:    sha256-RhczE44qTWpB1rzAKk5m/rEfhFNu7aXIzfKXpTxzO+o=

That's interesting. I just tried to build it again and it worked? In my case the derivation is also different though: /nix/store/s9lpvblksfqs3q6dbfrm8brjjddwv0h9-source.drv

Build log:

source> sourcing setup hook '/nix/store/dv5vgsw8naxnkcc88x78vprbnn1pp44y-patchelf-0.15.0/nix-support/setup-hook'
source> sourcing setup hook '/nix/store/i4iynx9axbq23sd0gyrc5wdb46zz6z8l-update-autotools-gnu-config-scripts-hook/nix-support/setup-hook'
source> sourcing setup hook '/nix/store/h9lc1dpi14z7is86ffhl3ld569138595-audit-tmpdir.sh'
source> sourcing setup hook '/nix/store/m54bmrhj6fqz8nds5zcj97w9s9bckc9v-compress-man-pages.sh'
source> sourcing setup hook '/nix/store/wgrbkkaldkrlrni33ccvm3b6vbxzb656-make-symlinks-relative.sh'
source> sourcing setup hook '/nix/store/5yzw0vhkyszf2d179m0qfkgxmp5wjjx4-move-docs.sh'
source> sourcing setup hook '/nix/store/fyaryjvghbkpfnsyw97hb3lyb37s1pd6-move-lib64.sh'
source> sourcing setup hook '/nix/store/kd4xwxjpjxi71jkm6ka0np72if9rm3y0-move-sbin.sh'
source> sourcing setup hook '/nix/store/pag6l61paj1dc9sv15l7bm5c17xn5kyk-move-systemd-user-units.sh'
source> sourcing setup hook '/nix/store/jivxp510zxakaaic7qkrb7v1dd2rdbw9-multiple-outputs.sh'
source> sourcing setup hook '/nix/store/ilaf1w22bxi6jsi45alhmvvdgy4ly3zs-patch-shebangs.sh'
source> sourcing setup hook '/nix/store/cickvswrvann041nqxb0rxilc46svw1n-prune-libtool-files.sh'
source> sourcing setup hook '/nix/store/xyff06pkhki3qy1ls77w10s0v79c9il0-reproducible-builds.sh'
source> sourcing setup hook '/nix/store/aazf105snicrlvyzzbdj85sx4179rpfp-set-source-date-epoch-to-latest.sh'
source> sourcing setup hook '/nix/store/gps9qrh99j7g02840wv5x78ykmz30byp-strip.sh'
source> exporting https://github.com/Vendicated/Vencord.git (rev v1.9.7) into /nix/store/967mcz7dgqmmgdds8n5kwblj8fkgbrkm-source
source> Initialized empty Git repository in /nix/store/967mcz7dgqmmgdds8n5kwblj8fkgbrkm-source/.git/
copying path '/nix/store/63g12hfzq40msw1vfdzpfcg9bp42gwir-pnpm-config-hook' from 'https://cache.nixos.org'...
source> remote: Enumerating objects: 824, done.
source> remote: Counting objects: 100% (824/824), done.
source> remote: Compressing objects: 100% (709/709), done.
source> remote: Total 824 (delta 117), reused 371 (delta 14), pack-reused 0 (from 0)
source> Receiving objects: 100% (824/824), 776.67 KiB | 6.64 MiB/s, done.
source> Resolving deltas: 100% (117/117), done.
source> From https://github.com/Vendicated/Vencord
source>  * tag               v1.9.7     -> FETCH_HEAD
source> Switched to a new branch 'fetchgit'
source> Enumerating objects: 824, done.
source> Counting objects: 100% (824/824), done.
source> Compressing objects: 100% (723/723), done.
source> Writing objects: 100% (824/824), done.
source> Total 824 (delta 118), reused 703 (delta 0), pack-reused 0 (from 0)
source> Enumerating objects: 824, done.
source> Nothing new to pack.

@KaylorBen KaylorBen mentioned this pull request Aug 23, 2024
Merged
@Scrumplex
vencord: refactor to use pnpm.fetchDeps
29bc58a 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
vencord: reformat using nixfmt
09e917c 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
vencord: 1.9.5 -> 1.9.7
1401c61 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
vencord: fix installPhase hooks
4e20584 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
vencord: sort inputs
a76791c 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
vencord: fix update script
877d23c 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
vencord: 1.9.7 -> 1.9.8
4309219 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex changed the title vencord: 1.9.5 -> 1.9.7 vencord: 1.9.5 -> 1.9.8 Aug 27, 2024
This was referenced Aug 27, 2024
Closed
Closed
@Scrumplex Scrumplex changed the title vencord: 1.9.5 -> 1.9.8 vencord: 1.9.5 -> 1.9.9 Sep 1, 2024
@Scrumplex
Copy link
Member Author

@FlafyDev @NotAShelf could one of you please take a look and review this PR?

@NotAShelf
Copy link
Member

will do as soon as I get home

@NotAShelf
Copy link
Member

Seems to be causing a hash mismatch:

error: hash mismatch in fixed-output derivation '/nix/store/s0vf0d8wbvqm1ck06qdf0k8bycsfzajq-source.drv':
        likely URL: https://github.com/Vendicated/Vencord.git
         specified: sha256-krNo5CMQ70xEAdsK8Ix/7L8wOJq8yyRbGj9o5NzRYfk=
            got:    sha256-PPzFCMifAeg9TosUwP/asvmSFIDDvdN7MHLeNNV2VH8=

@Scrumplex
Copy link
Member Author

This is odd. I wonder if leaveDotGit makes the source drv hash unstable? Because it definitely built fine for me before, but now it fails (after I gced the source)

@sersorrel
Copy link
Contributor

likewise:

error: hash mismatch in fixed-output derivation '/nix/store/yxzvm6r8afjgdibjz0v4azybgbbl9s38-source.drv':
        likely URL: https://github.com/Vendicated/Vencord.git
         specified: sha256-PPzFCMifAeg9TosUwP/asvmSFIDDvdN7MHLeNNV2VH8=
            got:    sha256-5AYIlmlmEpoDvFHbXH8W8JbDRw2Wbs0aSqt8GmQyCRs=

@Scrumplex
Copy link
Member Author

I think this is #8567

@Scrumplex
vencord: 1.9.8 -> 1.9.9
dc011c7 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
Copy link
Member Author

I have compromised on setting a hardcoded VENCORD_HASH that shouldn't be relevant for anything besides the updated (that is disabled in our build).

@Scrumplex
Copy link
Member Author

Please try again @sersorrel @NotAShelf 🙏

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4523

@sersorrel
Copy link
Contributor

"interesting" log message on build:

"WARN using --force I sure hope you know what you are doing"

but, it does build

Result of nixpkgs-review pr 332423 run on x86_64-linux 1

3 packages built:
  • vencord
  • vencord-web-extension
  • webcord-vencord

@Scrumplex
Copy link
Member Author

"interesting" log message on build:

"WARN using --force I sure hope you know what you are doing"

That's from pnpm.fetchDeps. --force just makes it download all node deps no matter the platform, processor and libc implementation.

@Infinidoge
Copy link
Contributor

Infinidoge commented Sep 5, 2024 •
edited
Loading

There's a new release, (v1.10.1), which fixes broken BetterFolders and the like.

@Scrumplex
vencord: 1.9.9 -> 1.10.1
176bc2d 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex
Copy link
Member Author

Result of nixpkgs-review pr 332423 run on x86_64-linux 1

3 packages built:
  • vencord
  • vencord-web-extension
  • webcord-vencord

@Scrumplex Scrumplex changed the title vencord: 1.9.5 -> 1.9.9 vencord: 1.9.5 -> 1.10.1 Sep 5, 2024
Infinidoge
Infinidoge approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Infinidoge Infinidoge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine, works great :)

Also the package looks to be significantly more maintainable now, which is good.

@NotAShelf
Copy link
Member

Seems to be running fine, LGTM.

@ofborg ofborg bot requested a review from NotAShelf September 5, 2024 19:55
@jopejoe1 jopejoe1 merged commit 5690cd6 into NixOS:master Sep 7, 2024
33 of 34 checks passed
@Scrumplex Scrumplex added the backport release-24.05 Backport PR automatically label Sep 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Sep 7, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Infinidoge Infinidoge Infinidoge approved these changes

@FlafyDev FlafyDev Awaiting requested review from FlafyDev

@NotAShelf NotAShelf Awaiting requested review from NotAShelf

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12.approvals: 2 12.approved-by: package-maintainer backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Scrumplex @mattpolzin @NotAShelf @sersorrel @nixos-discourse @Infinidoge @wegank @jopejoe1