Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installShellFiles: rework and add installBin function #332612

Merged
merged 12 commits into from
Aug 29, 2024
Merged

installShellFiles: rework and add installBin function #332612

merged 12 commits into from
Aug 29, 2024

Commits on Aug 28, 2024

  1. installShellFiles: move setup script to the same directory 

    So that it can be migrated to by-name later.
    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8f4200d View commit details
    Browse the repository at this point in the history

  2. installShellFiles: migrate tests to tests subdirectory 

    Rationale: Since RFCs 140 and 146, the old category-based hierarchy is
deprecated and obsolete, and a new approach took place: packages should be as
self-contained as possible.

This paradigm is reflected in many new strict checks that prohibit a package to
refer to files outside its directory tree.

Following this spirit, this commit essentially moves nixpkgs
pkgs/test/default.nix to ./tests/default.nix.

Further, to keep the top-level `tests` attribute, a green alias is kept in the
place of older file.
    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f72e74d View commit details
    Browse the repository at this point in the history

  3. installShellFiles: nixfmt-rfc-style

    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8b67437 View commit details
    Browse the repository at this point in the history

  4. installShellFiles: migrate to by-name

    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e548b31 View commit details
    Browse the repository at this point in the history

  5. installShellFiles: dismember tests into their own files 

    It makes the maintenance and creation of tests more intuitive: just throw a Nix
package under tests!
    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    98e9fbb View commit details
    Browse the repository at this point in the history

  6. installShellFiles: add new function installBin

    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1c9d479 View commit details
    Browse the repository at this point in the history

  7. installShellFiles: add new tests install-bin and install-bin-output

    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    507416c View commit details
    Browse the repository at this point in the history

  8. installShellFiles: rewrite functions 

    - Use FUNCNAME to track the name of function being called
- use long options for install commands
- use nix*Log functions for logging, instead of custom echoes
- remove silent error construction `|| return`
    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    bb5aa08 View commit details
    Browse the repository at this point in the history

  9. installShellFiles: set passthru directly instead of overriding it

    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    56ff398 View commit details
    Browse the repository at this point in the history

  10. doc: rewrite installShellFiles

    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1fc77a5 View commit details
    Browse the repository at this point in the history

  11. CODEOWNERS: update ownership for installShellFiles 

    Since Ericson2314 is the original codeowner of the files.
    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    32897dc View commit details
    Browse the repository at this point in the history

  12. nawk: uses installBin to install the binary

    @AndersonTorres
    AndersonTorres committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    618cffa View commit details
    Browse the repository at this point in the history