Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audiobookshelf: skip version checks #333691

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

mjoerg
Copy link
Contributor

@mjoerg mjoerg commented Aug 10, 2024

Description of changes

Make sure no external dependencies are downloaded, since we provide our own binaries.
Add nixos test as package test.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • audiobookshelf

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Make sure no external dependencies are downloaded, since we provide our own binaries.
Add nixos test as package test.
@adamcstephens
Copy link
Contributor

Awesome, thanks. I quickly merged 2.12.3 because it rolled back the sqlean download that I missed was added in 2.12.

@adamcstephens adamcstephens merged commit 27e5ee9 into NixOS:master Aug 10, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants