minetest: 5.8.0 -> 5.9.0 #334206
Merged
minetest: 5.8.0 -> 5.9.0 #334206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysedwinistrator
force-pushed
the
minetest-5.9.0
branch
from
506f697
to
a6115b0
Compare
emilazy
approved these changes
Aug 12, 2024
fgaz
requested changes
Aug 12, 2024
* remove irrlichtmt input. Minetest's irrlicht fork has been moved into the minetest repo and is now statically linked. * remove mesa from buildInputs for darwin. Otherwise startup fails with "OpenGL driver version is not 1.2 or better." and "Shaders are enabled but GLSL is not supported by the driver.". Presumably that happens because minetest tries to use an incomplete OpenGL driver from mesa instead of the drivers provided by macOS. * remove withTouchSupport arg, as the upstream CMake option has been removed. Touch support should now always be enabled. * make minetest-touch an alias for minetestclient * remove unused args
Irrlicht's SDL device (=backend) was enabled by default for the 5.9.0 pre-release, but was disabled again at the last minute before the release due to issues reported by some users. NOTE: the irrlicht device is a compile time option and cannot be switched at runtime.
sysedwinistrator
force-pushed
the
minetest-5.9.0
branch
from
a6115b0
to
d9145b5
Compare
fgaz
approved these changes
Aug 12, 2024
Minetest's irrlicht fork has been moved into the minetest repo.
sysedwinistrator
force-pushed
the
minetest-5.9.0
branch
from
d9145b5
to
8739341
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-334206-to-release-24.05 origin/release-24.05
cd .worktree/backport-334206-to-release-24.05
git switch --create backport-334206-to-release-24.05
git cherry-pick -x d61c03fe460f6349e5173e007fb2b678c33bed36 e9761ca2ae6c793ad3578444b5644bbdbcd0d607 873934134d0a0b237aa39a3ed31521d7a2df8326 |
|
I'm not sure a backport is appropriate. See https://dev.minetest.net/Changelog#Deprecations_and_compatibility_notes . This pr also removes a package and alters the parameters of another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.