Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmic-session: 0-unstable-2024-01-17 -> 1.0.0-alpha.1 #335417

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Aug 17, 2024

Description of changes

Obligatory: #327063
Part of: #259641

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@a-kenji
Copy link
Contributor Author

a-kenji commented Aug 18, 2024

Result of nixpkgs-review pr 335417 run on x86_64-linux 1

1 package built:
  • cosmic-session

@a-kenji a-kenji force-pushed the update-cosmic-session branch 3 times, most recently from 3e1c78d to e788e98 Compare August 23, 2024 10:43
Prefer `--replace-fail` to `--replace` in substituteInPlace.
@SuperSandro2000 SuperSandro2000 merged commit 56ea5e9 into NixOS:master Aug 26, 2024
24 of 26 checks passed
@a-kenji a-kenji deleted the update-cosmic-session branch August 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants