Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.blessings: drop #336152

Merged
merged 10 commits into from
Sep 22, 2024
Merged

python312Packages.blessings: drop #336152

merged 10 commits into from
Sep 22, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member

emilazy commented Aug 20, 2024

This package seems to be somewhat famously unmaintained, and there is a maintained fork in the form of Blessed that already uses pytest. We already have a python3Packages.blessed package; perhaps we can simply remove this. In‐tree users:

  • cbeams: Doesn’t look very maintained, but terminal.py seems simple enough that I expect the port is simple.
  • python3Packages.invocations: blessings is dead pyinvoke/invocations#38, looks like probably a one‐line import change to port to Blessed.
  • python3Packages.ronin: Build system with no commits for 7 years and no in‐tree users, not exposed in the top‐level package set, ditto on the port but we can probably just drop this.
  • python3Packages.reportengine: Marked as broken, unmaintained‐ish upstream, and could potentially just be dropped, but ditto on the port.

@Sigmanificient
Copy link
Member Author

@emilazy tried to makes reportengine passing, couldn't successfully patch it, so I dropped it. It also takes 2 other packages with it

@Sigmanificient
Copy link
Member Author

Result of nixpkgs-review pr 336152 run on x86_64-linux 1

10 packages built:
  • cbeams
  • cbeams.dist
  • python311Packages.invocations
  • python311Packages.invocations.dist
  • python311Packages.pytest-relaxed
  • python311Packages.pytest-relaxed.dist
  • python312Packages.invocations
  • python312Packages.invocations.dist
  • python312Packages.pytest-relaxed
  • python312Packages.pytest-relaxed.dist

pkgs/development/python-modules/blessings/default.nix Outdated Show resolved Hide resolved
@@ -513,6 +513,7 @@ mapAliases ({
recursivePthLoader = recursive-pth-loader; # added 2024-01-07
rednose = throw "rednose is no longer maintained (since February 2018)"; # added 2023-08-06
repeated_test = repeated-test; # added 2022-11-15
reportengine = throw "reportengine has been removed, since it is unmaintained and broken"; # added 2024-08-21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name it explicitly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to see what is problematic here

@@ -1522,6 +1522,7 @@ mapAliases ({
### V ###

v4l_utils = throw "'v4l_utils' has been renamed to/replaced by 'v4l-utils'"; # Converted to throw 2023-09-10
validphys2 = throw "validphys2 has been removed, since it has a broken dependency that was removed"; # Added 2024-08-21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -327,6 +327,7 @@ mapAliases ({
mrkd = throw "mrkd has been promoted to a top-level attribute name: `pkgs.mrkd`"; # added 2023-08-01
multi_key_dict = multi-key-dict; # added 2023-11-05
mutmut = throw "mutmut has been promoted to a top-level attribute name: `pkgs.mutmut`"; # added 2022-10-02
n3fit = throw "n3fit has been removed since it relies on a dependency that was removed"; # added 2024-08-24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the PR title? Otherwise this seems good to merge to me.

@emilazy
Copy link
Member

emilazy commented Sep 22, 2024

Result of nixpkgs-review pr 336152 run on aarch64-linux 1

10 packages built:
  • cbeams
  • cbeams.dist
  • python311Packages.invocations
  • python311Packages.invocations.dist
  • python311Packages.pytest-relaxed
  • python311Packages.pytest-relaxed.dist
  • python312Packages.invocations
  • python312Packages.invocations.dist
  • python312Packages.pytest-relaxed
  • python312Packages.pytest-relaxed.dist

@emilazy emilazy changed the title python312Packages.blessings: drop nose dependency python312Packages.blessings: drop Sep 22, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remembered I can do that myself :)

@emilazy emilazy merged commit 3b5f32c into NixOS:master Sep 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants