-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.blessings: drop #336152
Conversation
16736a4
to
ac54491
Compare
This package seems to be somewhat famously unmaintained, and there is a maintained fork in the form of Blessed that already uses pytest. We already have a
|
ac54491
to
5f9b114
Compare
5f9b114
to
bd6f33d
Compare
@emilazy tried to makes |
Result of 10 packages built:
|
@@ -513,6 +513,7 @@ mapAliases ({ | |||
recursivePthLoader = recursive-pth-loader; # added 2024-01-07 | |||
rednose = throw "rednose is no longer maintained (since February 2018)"; # added 2023-08-06 | |||
repeated_test = repeated-test; # added 2022-11-15 | |||
reportengine = throw "reportengine has been removed, since it is unmaintained and broken"; # added 2024-08-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please name it explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure to see what is problematic here
@@ -1522,6 +1522,7 @@ mapAliases ({ | |||
### V ### | |||
|
|||
v4l_utils = throw "'v4l_utils' has been renamed to/replaced by 'v4l-utils'"; # Converted to throw 2023-09-10 | |||
validphys2 = throw "validphys2 has been removed, since it has a broken dependency that was removed"; # Added 2024-08-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -327,6 +327,7 @@ mapAliases ({ | |||
mrkd = throw "mrkd has been promoted to a top-level attribute name: `pkgs.mrkd`"; # added 2023-08-01 | |||
multi_key_dict = multi-key-dict; # added 2023-11-05 | |||
mutmut = throw "mutmut has been promoted to a top-level attribute name: `pkgs.mutmut`"; # added 2022-10-02 | |||
n3fit = throw "n3fit has been removed since it relies on a dependency that was removed"; # added 2024-08-24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
0d7863d
to
b02dc5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the PR title? Otherwise this seems good to merge to me.
Result of 10 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remembered I can do that myself :)
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.